]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
iconGrid: Don't update pages in vfunc_allocate()
authorJonas Dreßler <verdre@v0yd.nl>
Tue, 23 Feb 2021 19:16:00 +0000 (20:16 +0100)
committerMarge Bot <marge-bot@gnome.org>
Wed, 3 Mar 2021 17:59:15 +0000 (17:59 +0000)
vfunc_allocate() is a hot path, and we don't want to do expensive stuff
there, so avoid updating the pages, which seems unnecessary anyway.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1713>

js/ui/iconGrid.js

index 30d9cdde31cf0529bb154d172cb94e4728ff5c30..27ffd733e0891be8ccde83f2d114c5b3c4782da5 100644 (file)
@@ -775,8 +775,6 @@ var IconGridLayout = GObject.registerClass({
         if (this._pageWidth === 0 || this._pageHeight === 0)
             throw new Error('IconGridLayout.adaptToSize wasn\'t called before allocation');
 
-        this._updatePages();
-
         const isRtl =
             Clutter.get_default_text_direction() === Clutter.TextDirection.RTL;
         const childSize = this._getChildrenMaxSize();